mypy: Remove follow-imports option from invocation#234
Open
djmoch wants to merge 1 commit intoklen:developfrom
Open
mypy: Remove follow-imports option from invocation#234djmoch wants to merge 1 commit intoklen:developfrom
djmoch wants to merge 1 commit intoklen:developfrom
Conversation
Follow imports is not recommended by the Mypy authors if it can be avoided[1], but adding it to the invocation forces users down that path. This can lead to unexpected errors trying to use `mypy` within pylama. This commit removes the forced option to skip following imports. Users will see the `mypy` linter take longer to run in most casees. If that is a problem, they can still configure it not to follow imports in any of the ways the tool supports. [1] - https://mypy.readthedocs.io/en/stable/running_mypy.html#follow-imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow imports is not recommended by the Mypy authors if it can be avoided, but adding it to the invocation forces users down that path. This can lead to unexpected errors trying to use Mypy within
pylama.This commit removes the forced option to skip following imports. Users will see the
mypylinter take longer to run in most cases. If that is a problem, they can still configure it not to follow imports in any of the ways the tool supports.