Merged
Conversation
Owner
klowdo
commented
Jan 13, 2026
klowdo
commented
- Extract duplicated email/phone icon rendering into nested ContactItemIcon class
- Replace magic numbers with named constants (IconSize, IconTextSize, etc.)
- Separate canvas drawing logic into DrawIconWithBackground method
- Make contact items data-driven for easier extensibility
- Remove unused commented-out code
- Extract duplicated email/phone icon rendering into nested ContactItemIcon class - Replace magic numbers with named constants (IconSize, IconTextSize, etc.) - Separate canvas drawing logic into DrawIconWithBackground method - Make contact items data-driven for easier extensibility - Remove unused commented-out code
Owner
Author
|
@claude can you check this |
Convert method reference to inline lambda to ensure compatibility with QuestPDF's Canvas delegate signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.