Open
Conversation
Member
|
Looks good to me. Happy to merge now or after you add a Poly3... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
probe file for neuronexus A1x16
I don't know how other labs map Neuronexus' site numbers onto array indices, so I added a dictionary where this mapping can be defined, so that
s[4]returns the channel (array index) that corresponds to Site 4.This should make it slightly more convenient for sharing electrodes with more complex architectures without each lab needing to rewrite the whole geometry for a different site:channel mapping.
(I have a Poly3 electrode I need to add to this PR, too)