Skip to content

Better position for error and notice message#71

Open
mafigit wants to merge 1 commit intokmerz:masterfrom
mafigit:better_error_message
Open

Better position for error and notice message#71
mafigit wants to merge 1 commit intokmerz:masterfrom
mafigit:better_error_message

Conversation

@mafigit
Copy link
Copy Markdown
Contributor

@mafigit mafigit commented Feb 9, 2014

  • since we included the error and notice message in the container of the
    page you were not able to see some of the error/notice messages, if
    you scrolled down too far.

- since we included the error and notice message in the container of the
  page you were not able to see some of the error/notice messages, if
  you scrolled down too far.
@kmerz
Copy link
Copy Markdown
Owner

kmerz commented Feb 9, 2014

When I login the error message is not in focus of the screen. It appears on the top to the right. So I don't really see it. This is not good :(

But we would have to deal with this differently anyway. Can you tell me where I can take a look where this change improves the error messages.

Don't get me wrong, we don't deal with errors good anyway and we should change that :) So I look forward for any improvement. I just can't see right now :)

@mafigit
Copy link
Copy Markdown
Contributor Author

mafigit commented Feb 9, 2014

for example when you like a post, but you are not logged in. you can not see the error message at all, if you scroll down too far.

@kmerz
Copy link
Copy Markdown
Owner

kmerz commented Feb 9, 2014

error

I don't think we should do it this way... But the problem stands!

@mafigit
Copy link
Copy Markdown
Contributor Author

mafigit commented Feb 9, 2014

Sorry didnt test it in such low resolution devices ;) but yes we should make it a bit different

@h5b h5b added the enhancement label Feb 9, 2014
@kmerz
Copy link
Copy Markdown
Owner

kmerz commented Feb 9, 2014

Uhh.. so you never shrink your window 🎱 :)

@mafigit
Copy link
Copy Markdown
Contributor Author

mafigit commented Nov 1, 2014

I am working on it :)

@kmerz
Copy link
Copy Markdown
Owner

kmerz commented Nov 1, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants