docs(rate-limiting): replace workloadSelector with targetRefs in rate limiting guide doc #256
Conversation
Signed-off-by: aicee <hhbin2000@foxmail.com>
✅ Deploy Preview for kmesh-net ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @zrggw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation for rate limiting to align with recent API changes. It specifically modifies the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully updates the documentation to replace workloadSelector with the more current targetRefs in the EnvoyFilter examples. The changes are accurate and reflect modern Istio configuration practices. However, I've identified an indentation error in one of the YAML examples that would cause it to fail if used directly. A code suggestion has been provided to correct this.
There was a problem hiding this comment.
Pull request overview
This PR updates the rate limiting guide documentation to use the modern targetRefs field instead of the deprecated workloadSelector field in EnvoyFilter configurations. This change aligns with Kubernetes Gateway API patterns for targeting specific Gateway resources.
Key changes:
- Updated prose description to reference
targetRefsinstead ofworkloadSelector - Replaced
workloadSelectorwithtargetRefsin all three EnvoyFilter examples - Updated selector format from label-based matching to Gateway resource reference
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I have replaced |
Signed-off-by: aicee <hhbin2000@foxmail.com>
Signed-off-by: aicee <hhbin2000@foxmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
Changes
workloadSelectorwithtargetRefsin all EnvoyFilter examples throughout the rate limiting guide