docs: add Chinese translation for circuit breaker document #261
Conversation
This commit adds the Chinese (zh) translation of the circuit breaker documentation to complete the i18n coverage for this feature. Fixes: kmesh-net#224 Signed-off-by: Gauarv Chaudhary <chaudharygaurav2004@gmail.com>
✅ Deploy Preview for kmesh-net ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @ANAMASGARD, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Chinese translation for the circuit breaker documentation, significantly enhancing accessibility for Chinese-speaking users. The added document provides a comprehensive, step-by-step guide to understanding and implementing Kmesh's circuit breaker feature, from initial setup and configuration to verifying its functionality through practical examples. This ensures that users can effectively leverage circuit breaking within their Kmesh environments with clear, localized instructions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the Chinese translation for the circuit breaker documentation. The overall translation quality is good. However, there are a few minor issues. A comment block within the fortio-deploy Deployment was not translated. Additionally, there are a couple of code blocks with an extra space before the language identifier. I've provided specific suggestions to address these points. After fixing these, the document will be in great shape.
|
|
||
| ## 步骤 2. 部署 fortio 和 httpbin | ||
|
|
||
| ``` sh |
There was a problem hiding this comment.
There is an extra space before the language identifier sh for this code block. For consistency with other code blocks in the document, it should be removed.
| ``` sh | |
| ```sh |
| # This annotation causes Envoy to serve cluster.outbound statistics via 15000/stats | ||
| # in addition to the stats normally served by Istio. The Circuit Breaking example task | ||
| # gives an example of inspecting Envoy stats via proxy config. |
There was a problem hiding this comment.
This comment block has not been translated. According to the PR description, all content should be translated. Please translate this comment to Chinese for completeness and consistency.
| # This annotation causes Envoy to serve cluster.outbound statistics via 15000/stats | |
| # in addition to the stats normally served by Istio. The Circuit Breaking example task | |
| # gives an example of inspecting Envoy stats via proxy config. | |
| # 此注解使 Envoy 通过 15000/stats 提供 cluster.outbound 统计信息， | |
| # 这是对 Istio 通常提供的统计信息的补充。熔断示例任务 | |
| # 提供了一个通过代理配置检查 Envoy 统计信息的示例。 |
|
|
||
| 首先，如果您尚未安装 Kubernetes Gateway API CRD，请运行以下命令进行安装。 | ||
|
|
||
| ``` sh |
There was a problem hiding this comment.
There is an extra space before the language identifier sh for this code block. For consistency with other code blocks in the document, it should be removed.
| ``` sh | |
| ```sh |
There was a problem hiding this comment.
Pull request overview
This PR adds a complete Chinese translation of the circuit breaker documentation to support Chinese-speaking users. The translation covers all steps for testing Kmesh's circuit breaking functionality, from deployment to observing the behavior.
- Translates the circuit breaker guide into Chinese (zh)
- Maintains consistent technical terminology with other Chinese documentation
- Preserves all commands, YAML configurations, and code examples
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # This annotation causes Envoy to serve cluster.outbound statistics via 15000/stats | ||
| # in addition to the stats normally served by Istio. The Circuit Breaking example task | ||
| # gives an example of inspecting Envoy stats via proxy config. |
There was a problem hiding this comment.
The English comments inside the YAML configuration (lines 42-44) should be translated to Chinese for consistency with the rest of the document. These comments explain the purpose of the annotation and should be localized like other text in this translation.
| # This annotation causes Envoy to serve cluster.outbound statistics via 15000/stats | |
| # in addition to the stats normally served by Istio. The Circuit Breaking example task | |
| # gives an example of inspecting Envoy stats via proxy config. | |
| # 该注解会让 Envoy 通过 15000/stats 暴露 cluster.outbound 相关统计数据 | |
| # 除了 Istio 默认提供的统计信息之外，“熔断”示例任务 | |
| # 还演示了如何通过 proxy config 查看 Envoy 的统计数据。 |
2 participants
Adds Chinese (zh) translation for the circuit breaker documentation.
Fixes #224