docs: add Chinese translation for global rate limit guide #262
Conversation
This commit introduces the Chinese (zh) translation for the rate limiting user guide, covering both local and global rate limiting scenarios. Fixes: kmesh-net#223 Signed-off-by: Gauarv Chaudhary <chaudharygaurav2004@gmail.com>
✅ Deploy Preview for kmesh-net ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @ANAMASGARD, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在通过提供 Kmesh 限流指南的中文翻译来增强文档的可访问性。这对于中文用户来说至关重要，因为它使他们能够以母语理解和应用限流功能，从而提升用户体验并解决社区提出的特定需求。该翻译内容全面，涵盖了本地限流和全局限流的部署、配置和测试步骤。 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the Chinese translation for the rate limiting documentation. The translation is generally well done. However, I've identified a couple of issues that need addressing. One is a command that will fail due to an incorrect reference, and the others are related to the use of absolute URLs that point to the English documentation instead of the corresponding Chinese pages. I have provided code suggestions to fix these issues.
| kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || \ | ||
| { kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref=v1.4.0" | kubectl create -f -; } |
There was a problem hiding this comment.
This command for installing the Gateway API CRDs has a couple of issues:
- The reference
ref=v1.4.0is not a valid tag or commit in thegateway-apirepository, which will cause thekustomizecommand to fail. - Using
kubectl createis not idempotent and can cause errors if the CRDs already exist. It's better to usekubectl apply.
To fix this and ensure consistency with other documentation in the repository, please update the reference and use kubectl apply.
| kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || \ | |
| { kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref=v1.4.0" | kubectl create -f -; } | |
| kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || \ | |
| { kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref=444631bfe06f3bcca5d0eadf1857eac1d369421d" | kubectl apply -f -; } |
|
|
||
| ### 1. 部署 Kmesh 和 istiod（版本 1.24 或更高版本） | ||
|
|
||
| 请阅读[快速入门](https://kmesh.net/docs/setup/quick-start)完成 Kmesh 的部署。 |
There was a problem hiding this comment.
The link to the quick start guide uses an absolute URL, which will direct users to the English version of the documentation. To ensure a consistent user experience within the translated documentation, it's best to use a relative path. Docusaurus will automatically resolve this to the correct localized page.
| 请阅读[快速入门](https://kmesh.net/docs/setup/quick-start)完成 Kmesh 的部署。 | |
| 请阅读[快速入门](../setup/quick-start)完成 Kmesh 的部署。 |
|
|
||
| ### 1. 部署 Kmesh 和 istiod（版本 1.24 到 1.26） | ||
|
|
||
| 请阅读[快速入门](https://kmesh.net/docs/setup/quick-start)完成 Kmesh 的部署。 |
There was a problem hiding this comment.
Similar to the previous comment, this link to the quick start guide uses an absolute URL that points to the English documentation. Please change it to a relative path to link to the Chinese version.
| 请阅读[快速入门](https://kmesh.net/docs/setup/quick-start)完成 Kmesh 的部署。 | |
| 请阅读[快速入门](../setup/quick-start)完成 Kmesh 的部署。 |
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive Chinese translation of the rate limiting documentation to improve accessibility for Chinese-speaking users.
- Translates the complete rate limiting guide covering both local and global rate limiting features
- Preserves all technical code examples, commands, and configuration snippets
- Maintains consistent technical terminology throughout the translation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
What this PR does
Adds the Chinese translation for the rate limiting documentation.
Why is it needed
Provides translated documentation for Chinese-speaking users, specifically addressing the global rate limit guide requested in #223.
Changes
i18n/zh/docusaurus-plugin-content-docs/current/application-layer/rate-limiting.mdFixes #223