Skip to content

Conversation

@zyzzmohit
Copy link

Fixes #147

Added docsVersionDropdown navbar item to enable users to select and view documentation for their specific Kmesh version.

Changes:

  • Added version dropdown between Documentation and Blog navbar items
  • Uses Docusaurus native versioning feature

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lizhencheng9527 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Jan 12, 2026

Deploy Preview for kmesh-net ready!

Name Link
🔨 Latest commit 469a842
🔍 Latest deploy log https://app.netlify.com/projects/kmesh-net/deploys/6964ee172b10040008731707
😎 Deploy Preview https://deploy-preview-270--kmesh-net.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kmesh-bot
Copy link
Collaborator

Welcome @zyzzmohit! It looks like this is your first PR to kmesh-net/website 🎉

@gemini-code-assist
Copy link

Summary of Changes

Hello @zyzzmohit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the documentation site by integrating a version selector dropdown into the navigation bar. This feature empowers users to effortlessly switch between different versions of the Kmesh documentation, ensuring they can always access the content relevant to their specific Kmesh installation. The change improves the overall usability and accessibility of the documentation.

Highlights

  • Docs Version Selector: A docsVersionDropdown navbar item has been added to enable users to select and view documentation for their specific Kmesh version.
  • Docusaurus Native Versioning: The implementation leverages Docusaurus's native versioning feature for managing and displaying different documentation versions.
  • Navbar Placement: The new version dropdown is positioned in the navbar between the existing 'Documentation' and 'Blog' links.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds a version selector dropdown to the documentation navbar using Docusaurus's built-in docsVersionDropdown feature. The implementation is straightforward and follows the desired placement. However, my review identified a critical dependency issue within the project's configuration. The project is configured to use React 19, which is incompatible with Docusaurus v3's requirement for React 18. This mismatch is likely to cause build or runtime errors, and it should be resolved to ensure the website's stability.

Comment on lines +94 to +98
{
type: "docsVersionDropdown",
position: "left",
dropdownActiveClassDisabled: true,
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this change correctly adds the version dropdown, I've identified a critical dependency issue that will likely prevent it from working. The project's package.json specifies React version ^19.0.0, but the Docusaurus version used in this project (@docusaurus/core@3.7.0) has a peer dependency on React ^18.0.0.

This incompatibility will likely cause build failures or runtime errors for the entire site. To fix this, please downgrade react and react-dom in package.json to a version compatible with Docusaurus v3, such as ^18.0.0.

@zyzzmohit zyzzmohit force-pushed the feat/docs-version-dropdown branch from 4766ac7 to cbb7209 Compare January 12, 2026 12:48
Added docsVersionDropdown navbar item to enable users to select
and view documentation for their specific Kmesh version.

Changes:
- Added version dropdown between Documentation and Blog navbar items
- Uses Docusaurus native versioning feature

Signed-off-by: zyzzmohit <mohitray949@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a versions section in the website, so that the user can select the preffered docs for the kmesh version he is using

2 participants