Skip to content

Conversation

@Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Sep 3, 2025

While implementing the request reply control plane, a few changes were needed in the request reply types for the feature to work correctly. This PR has those type changes.

Proposed Changes

  • To simplify for v1alpha1, secrets are managed by us - not externally. As such, the secrets field was removed
  • Desired and Ready Replicas were added to track trigger statuses between reconciliations
  • A label to the broker was added to request reply resources so that the reconciler can find resources associated with the broker
  • The timeout string default was switched to be a proper parseable duration
  • Broker status was added to the resource status as the broker should be ready before this accepts events

Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2025
@knative-prow knative-prow bot requested review from matzew and pierDipi September 3, 2025 14:00
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.56%. Comparing base (54ff928) to head (af5debb).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...g/apis/eventing/v1alpha1/requestreply_lifecycle.go 33.33% 4 Missing ⚠️
.../apis/eventing/v1alpha1/requestreply_validation.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8698      +/-   ##
==========================================
- Coverage   51.58%   51.56%   -0.02%     
==========================================
  Files         401      401              
  Lines       25431    25446      +15     
==========================================
+ Hits        13119    13122       +3     
- Misses      11509    11523      +14     
+ Partials      803      801       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Member Author

Cali0707 commented Sep 3, 2025

/cc @matzew @creydr

RequestReplyConditionTriggers apis.ConditionType = "TriggersReady"
RequestReplyConditionAddressable apis.ConditionType = "Addressable"
RequestReplyConditionEventPoliciesReady apis.ConditionType = "EventPoliciesReady"
RequestreplyConditionBrokerReady apis.ConditionType = "BrokerReady"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make this consistent, and do CamelCase -> RequestReplyConditionBrokerReady

Kind: "Broker",
Name: "broker",
},
Timeout: ptr.To("PT30S"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add test for invalid TO as well?

Signed-off-by: Calum Murray <cmurray@redhat.com>
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit c9cfca8 into knative:main Sep 8, 2025
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants