Skip to content

Conversation

@Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Sep 3, 2025

This enables the custom CESQL function in the webhook and trigger filter runtimes so that the request reply feature works there.

Proposed Changes

  • Enable CESQL function in webhook for trigger validation
  • Enable CESQL function in filter for actual running of the filters
Eventing Core triggers now support the KN_VERIFY_CORRELATION_ID CESQL function

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot requested review from aliok and aslom September 3, 2025 14:53
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 3, 2025
@Cali0707
Copy link
Member Author

Cali0707 commented Sep 3, 2025

/cc @creydr @matzew

@knative-prow
Copy link

knative-prow bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from creydr September 3, 2025 14:53
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2025
@knative-prow knative-prow bot requested a review from matzew September 3, 2025 14:53
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.58%. Comparing base (54ff928) to head (0e7745e).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cmd/broker/filter/main.go 0.00% 3 Missing ⚠️
cmd/webhook/main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8700      +/-   ##
==========================================
- Coverage   51.58%   51.58%   -0.01%     
==========================================
  Files         401      401              
  Lines       25431    25437       +6     
==========================================
+ Hits        13119    13121       +2     
- Misses      11509    11516       +7     
+ Partials      803      800       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matzew
Copy link
Member

matzew commented Sep 4, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2025
@knative-prow knative-prow bot merged commit e24129c into knative:main Sep 4, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants