Skip to content

Fix mt-broker-ingress auth to work with structured event too #8710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 3 commits into from
Sep 10, 2025
Merged

Fix mt-broker-ingress auth to work with structured event too #8710

knative-prow merged 3 commits into from
Sep 10, 2025

Conversation

@creydr
Copy link
Member

@creydr creydr commented Sep 9, 2025

Fixes #8707

@creydr creydr requested a review from maschmid September 9, 2025 14:14
@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Sep 9, 2025
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2025
@codecov
Copy link

codecov bot commented Sep 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 43.24324% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.61%. Comparing base (8c44e16) to head (f8211ac).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/utils/utils.go 57.14% 6 Missing and 3 partials ⚠️
pkg/channel/event_receiver.go 25.00% 5 Missing and 1 partial ⚠️
pkg/broker/ingress/ingress_handler.go 28.57% 4 Missing and 1 partial ⚠️
pkg/auth/verifier.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8710      +/-   ##
==========================================
+ Coverage   51.59%   51.61%   +0.01%     
==========================================
  Files         401      401              
  Lines       25431    25459      +28     
==========================================
+ Hits        13122    13141      +19     
- Misses      11507    11511       +4     
- Partials      802      807       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Cali0707
Cali0707 approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for fixing @creydr !

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
matzew
matzew reviewed Sep 9, 2025
View reviewed changes
pkg/utils/utils.go

// CopyRequest makes a copy of the http request which can be consumed as needed, leaving the original request
// able to be consumed as well.
func CopyRequest(req *http.Request) (*http.Request, error) {
Copy link
Member

@matzew matzew Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanna add a test to utils_test?

Copy link
Member Author

@creydr creydr Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 f8211ac

@maschmid
Copy link
Contributor

maschmid commented Sep 9, 2025

https://github.com/knative/eventing/blob/main/pkg/channel/event_receiver.go#L285-L319 looks like a similar problem.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025
@creydr creydr requested a review from Cali0707 September 10, 2025 12:19
@Cali0707 Cali0707 mentioned this pull request Sep 10, 2025
Merged
Cali0707
Cali0707 approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member Author

creydr commented Sep 10, 2025

/test upgrade-tests

@knative-prow knative-prow bot merged commit 941dafa into knative:main Sep 10, 2025
35 of 36 checks passed
@creydr
Copy link
Member Author

creydr commented Sep 10, 2025

/cherry-pick release-1.19

@creydr
Copy link
Member Author

creydr commented Sep 10, 2025

/cherry-pick release-1.18

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Sep 10, 2025

@creydr: new pull request created: #8713

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Sep 10, 2025
Merged
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Sep 10, 2025

@creydr: new pull request created: #8714

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Sep 10, 2025
Merged
creydr added a commit to creydr/knative-eventing that referenced this pull request Sep 10, 2025
@creydr
Fix mt-broker-ingress auth to work with structured event too (knative…
018ea09 
…#8710)

* Fix mt-broker-ingress auth to work with structured event too

* Fix channel receiver auth to work with structured event too

* Add unit test
openshift-merge-bot bot pushed a commit to openshift-knative/eventing that referenced this pull request Sep 29, 2025
@creydr
Fix mt-broker-ingress auth to work with structured event too (knative…
63e21ff 
…#8710) (#1588)

* Fix mt-broker-ingress auth to work with structured event too

* Fix channel receiver auth to work with structured event too

* Add unit test
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/knative-eventing that referenced this pull request Sep 29, 2025
@creydr
Fix mt-broker-ingress auth to work with structured event too (knative…
7ee8799 
…#8710)

* Fix mt-broker-ingress auth to work with structured event too

* Fix channel receiver auth to work with structured event too

* Add unit test
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/knative-eventing that referenced this pull request Sep 29, 2025
@creydr
Fix mt-broker-ingress auth to work with structured event too (knative…
62c3fd1 
…#8710)

* Fix mt-broker-ingress auth to work with structured event too

* Fix channel receiver auth to work with structured event too

* Add unit test
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/knative-eventing that referenced this pull request Sep 29, 2025
@creydr
Fix mt-broker-ingress auth to work with structured event too (knative…
c8ef647 
…#8710)

* Fix mt-broker-ingress auth to work with structured event too

* Fix channel receiver auth to work with structured event too

* Add unit test
openshift-merge-bot bot pushed a commit to openshift-knative/eventing that referenced this pull request Sep 30, 2025
@openshift-cherrypick-robot @creydr
Fix mt-broker-ingress auth to work with structured event too (knative…
dc2bbb9 
…#8710) (#1683)

* Fix mt-broker-ingress auth to work with structured event too

* Fix channel receiver auth to work with structured event too

* Add unit test

Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew left review comments

@Cali0707 Cali0707 Cali0707 approved these changes

@maschmid maschmid Awaiting requested review from maschmid

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@Cali0707 Cali0707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MTChannelBasedBroker doesn't accept structured events with EventPolicy enabled

5 participants

@creydr @maschmid @knative-prow-robot @matzew @Cali0707