Skip to content

Docs: Fix typo in development guide #8829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankurv37 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docs: Fix typo in development guide #8829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/broker/filtering.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ spec:
Cannot be specified with the SourceAndType filter.

_This example assumes the repository name is available as a CloudEvents
extension `{"repository":proposals"}`._
extension `{"repository":"proposals"}`._

Specified with the attributes filter:

Expand Down Expand Up @@ -309,7 +309,7 @@ spec:
Cannot be specified with the SourceAndType filter.

_This example assumes the repository name is available as a CloudEvents
extension `{"github.repository":proposals"}`._
extension `{"github.repository":"proposals"}`._

Specified with the attributes filter:

Expand Down Expand Up @@ -350,7 +350,7 @@ spec:
Cannot be specified with the SourceAndType filter or the attributes filter.

_This example assumes the event data is the parseable equivalent of
`{"user":{"id":"abc123"}`._
`{"user":{"id":"abc123"}}`._

```yaml
spec:
Expand Down
1 change: 1 addition & 0 deletions docs/decisions/eventing-and-messaging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,5 @@ additional repos in the release process.
## Source documents

[Proposal by Mark Fisher](https://docs.google.com/document/d/1w5Bd5kEiiMk7i7X0EUdy6PFbWUpwGTwep8I0N52esyM/edit#)

[Decision by eventing approvers](https://docs.google.com/spreadsheets/d/16aOhfRnkaGcQIOR5kiumld-GmrgGBIm9fppvAXx3mgc/edit?)
4 changes: 2 additions & 2 deletions docs/delivery/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ these situations.
### Dead Letter Sink

Channels are responsible for forwarding received events to subscribers. When
they fail to do so, they are responsible for sending the failing events to an
they fail to do so, they are responsible for sending the failing events to a
**dead letter sink**, potentially one per subscriber.

Similarly Event Sources are responsible for sending events to a sink and when
they fail to do so, they are responsible for sending the failing events to an
they fail to do so, they are responsible for sending the failing events to a
**dead letter sink**.

The dead letter sink can be a channel but it does not have to.
Expand Down