Skip to content

Add timeout to the delivery spec #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slinkydeveloper wants to merge 1 commit into from
Closed

Add timeout to the delivery spec #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions specs/eventing/spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ retrieved from ref.
| `deadLetterSink` | [`duckv1.Destination`](#duckv1.Destination) | Optional | The sink receiving event that could not be sent to a `Destination`. | |
| `retry` | `int` | Optional | The minimum number of retries the sender should attempt when sending an event before moving it to the dead letter sink (when specified) or discarded (otherwise). | |
| `backoffPolicy` | `string` | Optional | The retry backoff policy (`linear` or `exponential`). | |
| `timeout` | `string` | Optional | The timeout of each single request. | |
Copy link

@n3wscott n3wscott Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is a behaviour change for Brokers (all implementations), Triggers, Channels (all implementations), Subscriptions, Sequence, and Parallel.

Copy link
Contributor

@duglin duglin Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to say what happens if we hit the timeout? e.g. what should be the error seen?

Copy link
Contributor

@duglin duglin May 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a timeout per attempt (eg like an http timeout) or the total time you hold on to the event including all retries?

| `backoffDelay` | `string` | Optional | For linear policy, backoff delay is backoffDelay\*\<numberOfRetries>. For exponential policy, backoff delay is backoffDelay\*2^\<numberOfRetries>. | |

### SubscriberStatus
Expand Down