Skip to content

Changes to work with LTS-16.31 (GHC-8.8.4)#6

Open
saurabhnanda wants to merge 4 commits intoknrafto:masterfrom
vacationlabs:lts-16.31
Open

Changes to work with LTS-16.31 (GHC-8.8.4)#6
saurabhnanda wants to merge 4 commits intoknrafto:masterfrom
vacationlabs:lts-16.31

Conversation

@saurabhnanda
Copy link
Contributor

No description provided.

@saurabhnanda saurabhnanda changed the title Changes to work with LTS-16.31 (GHC-8.4.4) Changes to work with LTS-16.31 (GHC-8.8.4) Dec 29, 2021
@knrafto
Copy link
Owner

knrafto commented Dec 29, 2021

Thank you! Github says there are conflicts, can you resolve them?

@saurabhnanda
Copy link
Contributor Author

@knrafto just a single conflict in stack.yaml. What do you want the stack resolver in master to be? LTS-12.1 or LTS-16.31? Or should we have different stack.yaml files? One for each version of GHC that this package works with?

@knrafto
Copy link
Owner

knrafto commented Jan 4, 2022

The GHC version in master is ancient only because it hasn't been touched in a while.

I cherry-picked your commit to master and fixed it up so it would build on my machine. I had to set text-icu >= 0.7.1.0 to build on macOS, so I bumped the stack resolver to lts-18.21, GHC 8.10.7. Does that work for you? If not we can do separate stack files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants