Skip to content

Conversation

@asimtahir-karakus-kd
Copy link
Collaborator

Fixes: #4

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves error message readability by inserting line breaks before error messages in the streempublic.js file. The changes ensure that error messages appear on a new line, which is particularly important after progress bar output.

  • Adds newline output before error messages in the getFile error handler
  • Wraps the getFile call in a try-catch block with consistent error formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

} catch (err) {
process.stdout.write('\n');
error('Error downloading MainFrame Xpublic zip file:');
error(err);
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The try-catch block catches errors but doesn't prevent the function from continuing execution. After an error occurs during file download, the code proceeds to lines 78-82 where it attempts to unzip a file that may not exist (localzipfile), which will cause additional errors. The catch block should either re-throw the error or return early to prevent further execution.

Suggested change
error(err);
error(err);
throw err;

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should insert line break before print errors

2 participants