Added some missing dom methods and properties#313
Open
niloc132 wants to merge 4 commits intokonsoletyper:masterfrom
Open
Added some missing dom methods and properties#313niloc132 wants to merge 4 commits intokonsoletyper:masterfrom
niloc132 wants to merge 4 commits intokonsoletyper:masterfrom
Conversation
konsoletyper
requested changes
Nov 5, 2017
| public interface DOMTokenList extends JSArrayReader<JSString> { | ||
| boolean contains(String token); | ||
|
|
||
| void add(String... tokens); |
Owner
There was a problem hiding this comment.
I'm not sure if varargs are supported in JSO. Please check. If they aren't, let's think how we can work-around this. And don't forget to create an issue to support vararg.
Contributor
Author
There was a problem hiding this comment.
A good question - I'll verify more thoroughly, but I can verify that calling add(String...) with a single argument does work as expected presently.
Ihromant
added a commit
to Ihromant/teavm
that referenced
this pull request
Nov 23, 2023
Ihromant
added a commit
to Ihromant/teavm
that referenced
this pull request
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are broken into distinct commits, let me know if you want to get them merged one at a time.