Update nanogui and use our own mainloop#221
Open
petterarvidsson wants to merge 4 commits intomasterfrom
Open
Conversation
Member
Author
|
@nsg What do you think? |
- Added our own main loop that follows vsync
370a845 to
22687ed
Compare
Member
Author
|
Apparently they moved from glew to glad for windows compatibility... ugh... |
9041a8f to
715f31b
Compare
Member
|
@petterarvidsson Looks good, a little work to keep all these callbacks up-2-date in the future but over all this is a good thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make it easy to follow nanogui development, remove our changes and instead implement a simple main loop of our won based on: https://github.com/wjakob/nanogui/blob/master/src/example3.cpp
Also replace nanogui dependency with the one directly from https://github.com/wjakob/nanogui