Савенко Дмитрий#207
Open
Asrom11 wants to merge 1 commit intokontur-courses:masterfrom
Open
Conversation
SlavikGh0st
reviewed
Jan 23, 2025
| .SelectMany(reader => reader.SupportedDocumentExtensions.Select(ext => new { ext, reader })) | ||
| .ToDictionary(x => x.ext, x => x.reader); | ||
| } | ||
| public Result<string[]?> ReadDocument(string filePath) |
There was a problem hiding this comment.
Почему string[]? ?
Когда мы тут без ошибки null вернём?
SlavikGh0st
reviewed
Jan 23, 2025
|
|
||
| public Result<string[]?> ReadDocument(string filePath) | ||
| { | ||
| using var doc = WordprocessingDocument.Open(filePath, false); |
There was a problem hiding this comment.
А тут не будет ошибки, если документа по пути не найдется?
SlavikGh0st
reviewed
Jan 23, 2025
| var options = optionsResult.Value; | ||
| var containerResult = Result.Of(() => DependencyInjectionConfig.BuildContainer(options), | ||
| "Ошибка при настройке контейнера зависимостей."); | ||
| if (containerResult.IsSuccess) |
There was a problem hiding this comment.
Неправильное условие: из-за этого программа не запускается
SlavikGh0st
reviewed
Jan 23, 2025
| var generatorResult = Result.Of(() => | ||
| scope.Resolve<ITagCloudGenerator>(), | ||
| "Ошибка при разрешении зависимости ITagCloudGenerator."); | ||
| if (generatorResult.IsSuccess) |
There was a problem hiding this comment.
Неправильное условие: из-за этого программа не запускается
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SlavikGh0st