Fix: Waveshare ESP32-S3 LCD7 Display Rotation#147
Open
bonaminGR wants to merge 1 commit intokoosoli:mainfrom
Open
Fix: Waveshare ESP32-S3 LCD7 Display Rotation#147bonaminGR wants to merge 1 commit intokoosoli:mainfrom
bonaminGR wants to merge 1 commit intokoosoli:mainfrom
Conversation
Owner
|
Hi, thanks for the commit, I will need to get the 0.9 pre released bug fixed first, but after that, I will take a close look at your commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on a Waveshare ESP32-S3-Touch-LCD-7, and while it does generally work, the image is rotated.
Changing the rotation: 90 to 0 fixes the issue.
I am not exactly a programmer, and this is my first ever pull request, so if I did anything wrong, please feel free to ignore the issue. I just wanted to add my 2 cents on the project. ;)