Open
Conversation
keitap
force-pushed
the
add_user_task_list
branch
from
3916544 to
89ec19e
Compare
kothar
requested changes
Oct 23, 2022
Owner
kothar
left a comment
kothar
left a comment
There was a problem hiding this comment.
Thanks, that's handy, I think I will need this soon myself!
Regarding the CLI tool, the addition looks fine. It was only really there for testing, but it probably needs a bit of an overhaul.
| // | ||
| // Note: The API will only return workspaces and organizations that also | ||
| // contain the authenticated user. | ||
| Workspaces []*Workspace `json:"workspaces,omitempty"` |
Owner
There was a problem hiding this comment.
This should be a single Workspace according to the API docs:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented the Get user task list API because I needed it.
I'm not sure my implementation of command line tool is okay or not.