If wifi isn't connected skips the setupAndroidProxy() method (issue 289)#333
Open
juanmougan wants to merge 2 commits intokoush:masterfrom
Open
If wifi isn't connected skips the setupAndroidProxy() method (issue 289)#333juanmougan wants to merge 2 commits intokoush:masterfrom
juanmougan wants to merge 2 commits intokoush:masterfrom
Conversation
added 2 commits
March 19, 2015 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible fix to issue 289. If the user application wants to provide a Context, the library can check wifi status, and skip the proxy setup if wifi isn't enabled. Otherwise, the library will behave exactly as it does right now.