Add #[speedy(non_exhaustive)] struct attribute#22
Open
merlleu wants to merge 9 commits intokoute:masterfrom
Open
Add #[speedy(non_exhaustive)] struct attribute#22merlleu wants to merge 9 commits intokoute:masterfrom
merlleu wants to merge 9 commits intokoute:masterfrom
Conversation
Contributor
Author
|
I forked your serde-bench repo & added NonExhaustive benchmarks: https://github.com/merlleu/serde-bench |
Contributor
Author
|
My last commit attempted to reduce the performance delta between non_exhaustive & standard speedy: approx constant+10ns when serializing or deserializing structs. |
Contributor
Author
|
Current benchmarks: |
add speedy(non_exhaustive) rename attrs_c to attrs in Struct::new add description to readme switched to varint64 for struct field count && added tests use u7 instead of varint64 when possible remove duplicate checks for non_exhaustive change order of u7 patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I implemented #20, this allows users to have the choice to a little bit less space efficient / slower but be able to append fields to their structs without breaking the parsing of older data.
(this PR also removes the file "log", left in my previous PR).
TODO: