Fix #79 - avoid UB when writing lots of ZST's#80
Open
finnbear wants to merge 3 commits intokoute:masterfrom
Open
Fix #79 - avoid UB when writing lots of ZST's#80finnbear wants to merge 3 commits intokoute:masterfrom
finnbear wants to merge 3 commits intokoute:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79
Technically the issue also affects
{Hash, BTree}{Map, Set}but having more than0x7FFFFFFF_FFFFFFFFZST's with different hash values or different comparisons seems difficult to do by accident.I would add a test but this is impractical to test in debug mode and/or Miri, because it's too slow. Testing in release mode would work, but that wouldn't catch the original UB.