Nested assignments #37
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
Here's a one-character fix (after hours of pain and suffering!)... making
insert-assignmentsrecurse into blocks. Or was there a reason that was commented out?I'm not sure if this is fully general, to recurse only into blocks, or if it should walk everything (by mapping over
:body). Still hazy about how this all works.Another approach which could also fix my case would be to lift all the assignments to the top level, instead of a local block. I think the downside there is potential inefficiency in case conditional calculations are not used.
I also added a basic test, just covers this one case so far.