Fix heap buffer overflow for string_match benchmark when NO_MMAP flag is used.#10
Open
dimstav23 wants to merge 1 commit intokozyraki:masterfrom
Open
Fix heap buffer overflow for string_match benchmark when NO_MMAP flag is used.#10dimstav23 wants to merge 1 commit intokozyraki:masterfrom
string_match benchmark when NO_MMAP flag is used.#10dimstav23 wants to merge 1 commit intokozyraki:masterfrom
Conversation
…_MMAP case to eliminate the heap buffer overflow
string_match benchmark when NO_MMAP flag is used.string_match benchmark when NO_MMAP flag is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing:
Fixes #9
This PR adapts the buffer allocation for the
string_matchbenchmark when theNO_MMAPflag is set to eliminate the heap buffer overflow detected byASan.How to test this PR:
Compile the benchmarks with a patch that enables the
NO_MMAPflag andAddressSanitizer(ASan):Retrieve the inputs for the
string_matchbenchmark:Run the
string_matchbenchmark and observe the output ofASan:With the change included in this PR,
ASandoes not report any heap buffer overflow error.Tested on:
OS:
Ubuntu 22.04.4 LTSKernel:
6.2.0-39-genericgcc:
11.4.0