Conversation
|
Hi! I'm just wondering what the context is for this. Is this being added to the paper, or is it a repo-only addition? Will there be more of this kind of thing showing up over time? I thought the paper was submitted to a journal already, and I haven't seen any chat about post-submission revisions. I'm rather swamped with work right now, so I guess I'm wondering what the urgency is for this, and whether I ought to be expecting more on the way. :-> Thanks! |
Hey @bhaller! @Jrodriguez216 was working on this for a separate project, but I thought it was cool and could be a nice addition to this catalogue, so encouraged her to PR. No plans to incorporate it into the paper. Don't imagine a ton more of these will be coming down the pipes any time soon. If we want to leave this repo as a reflection of what's in the paper, I think that's fine. No rush. Just thought it would be good to get eyes on it from the pros since really only her and I have spent time on it. |
Hi @silastittes! Aha, I see. :->
I have no opinion on that one way or the other, so far (will need to think on it and hear people's thoughts); but maybe a good question for the group?
Gotcha. I'll circle back to it once I've handled some other things, then; quite snowed under at present. :-> |
Agree it's worth seeing what team wants to do in that regard!
Awesome, I think @Jrodriguez216 can move forward with what she's got, but greatly appreciated if/when bandwidth allows. |
|
Hey folks. I'm a little less slammed now, briefly. :-> Is this review still needed, and is this still the right place to do it? |
Yes based on slack convo, I think here is good! Any more commits to push first @Jrodriguez216? |
bhaller
left a comment
There was a problem hiding this comment.
Some thoughts, I hope they're helpful. Sorry this took me so long; life is busy right now...
|
Thank you for the thorough review @bhaller! I will check in with @Jrodriguez216! Pondering the optimum issue you raised. Maybe have a question or too soon. |
|
Thanks @bhaller !!! I'll be going through this today |
|
All changes made :) |
|
I think this was left in pretty good shape, wondering if this is ok to merge? |
I've added my current slim script of NWF Local Adaptation, along with a brief ReadMe and the toy image of heterogenous landscape.