Skip to content

local adaptation dir#36

Open
jordannrodriguez wants to merge 2 commits intokr-colab:mainfrom
jordannrodriguez:localadaptationsim
Open

local adaptation dir#36
jordannrodriguez wants to merge 2 commits intokr-colab:mainfrom
jordannrodriguez:localadaptationsim

Conversation

@jordannrodriguez
Copy link
Copy Markdown

I've added my current slim script of NWF Local Adaptation, along with a brief ReadMe and the toy image of heterogenous landscape.

@bhaller
Copy link
Copy Markdown
Collaborator

bhaller commented Oct 9, 2024

Hi! I'm just wondering what the context is for this. Is this being added to the paper, or is it a repo-only addition? Will there be more of this kind of thing showing up over time? I thought the paper was submitted to a journal already, and I haven't seen any chat about post-submission revisions. I'm rather swamped with work right now, so I guess I'm wondering what the urgency is for this, and whether I ought to be expecting more on the way. :-> Thanks!

@silastittes
Copy link
Copy Markdown
Contributor

Hi! I'm just wondering what the context is for this. Is this being added to the paper, or is it a repo-only addition? Will there be more of this kind of thing showing up over time? I thought the paper was submitted to a journal already, and I haven't seen any chat about post-submission revisions. I'm rather swamped with work right now, so I guess I'm wondering what the urgency is for this, and whether I ought to be expecting more on the way. :-> Thanks!

Hey @bhaller! @Jrodriguez216 was working on this for a separate project, but I thought it was cool and could be a nice addition to this catalogue, so encouraged her to PR. No plans to incorporate it into the paper. Don't imagine a ton more of these will be coming down the pipes any time soon. If we want to leave this repo as a reflection of what's in the paper, I think that's fine. No rush. Just thought it would be good to get eyes on it from the pros since really only her and I have spent time on it.

@bhaller
Copy link
Copy Markdown
Collaborator

bhaller commented Oct 9, 2024

Hey @bhaller!

Hi @silastittes! Aha, I see. :->

If we want to leave this repo as a reflection of what's in the paper, I think that's fine.

I have no opinion on that one way or the other, so far (will need to think on it and hear people's thoughts); but maybe a good question for the group?

No rush. Just thought it would be good to get eyes on it from the pros since really only her and I have spent time on it.

Gotcha. I'll circle back to it once I've handled some other things, then; quite snowed under at present. :->

@silastittes
Copy link
Copy Markdown
Contributor

silastittes commented Oct 9, 2024

Hey @bhaller!

Hi @silastittes! Aha, I see. :->

If we want to leave this repo as a reflection of what's in the paper, I think that's fine.

I have no opinion on that one way or the other, so far (will need to think on it and hear people's thoughts); but maybe a good question for the group?

Agree it's worth seeing what team wants to do in that regard!

No rush. Just thought it would be good to get eyes on it from the pros since really only her and I have spent time on it.

Gotcha. I'll circle back to it once I've handled some other things, then; quite snowed under at present. :->

Awesome, I think @Jrodriguez216 can move forward with what she's got, but greatly appreciated if/when bandwidth allows.

@jordannrodriguez
Copy link
Copy Markdown
Author

Hey @bhaller!

Hi @silastittes! Aha, I see. :->

If we want to leave this repo as a reflection of what's in the paper, I think that's fine.

I have no opinion on that one way or the other, so far (will need to think on it and hear people's thoughts); but maybe a good question for the group?

Agree it's worth seeing what team wants to do in that regard!

No rush. Just thought it would be good to get eyes on it from the pros since really only her and I have spent time on it.

Gotcha. I'll circle back to it once I've handled some other things, then; quite snowed under at present. :->

Awesome, I think @Jrodriguez216 can move forward with what she's got, but greatly appreciated if/when bandwidth allows.

Yes, thanks for the speedy replies @silastittes, and thanks for your consideration @bhaller, no rush or worries! :)

@bhaller
Copy link
Copy Markdown
Collaborator

bhaller commented Oct 22, 2024

Gotcha. I'll circle back to it once I've handled some other things, then; quite snowed under at present. :->

Awesome, I think @Jrodriguez216 can move forward with what she's got, but greatly appreciated if/when bandwidth allows.

Hey folks. I'm a little less slammed now, briefly. :-> Is this review still needed, and is this still the right place to do it?

@silastittes
Copy link
Copy Markdown
Contributor

Gotcha. I'll circle back to it once I've handled some other things, then; quite snowed under at present. :->

Awesome, I think @Jrodriguez216 can move forward with what she's got, but greatly appreciated if/when bandwidth allows.

Hey folks. I'm a little less slammed now, briefly. :-> Is this review still needed, and is this still the right place to do it?

Yes based on slack convo, I think here is good! Any more commits to push first @Jrodriguez216?

Copy link
Copy Markdown
Collaborator

@bhaller bhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts, I hope they're helpful. Sorry this took me so long; life is busy right now...

@silastittes
Copy link
Copy Markdown
Contributor

Thank you for the thorough review @bhaller! I will check in with @Jrodriguez216! Pondering the optimum issue you raised. Maybe have a question or too soon.

@jordannrodriguez
Copy link
Copy Markdown
Author

Thanks @bhaller !!! I'll be going through this today

@jordannrodriguez
Copy link
Copy Markdown
Author

All changes made :)

@jordannrodriguez
Copy link
Copy Markdown
Author

I think this was left in pretty good shape, wondering if this is ok to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants