Open
Conversation
If multiple VkMemoryPropertyFlags were required, the function checked if *any* flag was supported instead of checking for *all* flags.
vkMapMemory failed because the memory lacked VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT. Require that bit. Drop the requirement for VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT because (a) it is unneeded and (b) it may intefere with finding a type that supports VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT. Fail if protected mode is requested on the cmdline because host-visible protected memory is useless and contradictory. With these fixes, find_image_memory() is now independent of images. So rename it choose_memory_type_index().
It's merely a special case of choose_memory_type_index().
Contributor
Author
|
cc @dawnhan1111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vkMapMemory failed because the memory lacked
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT. Require that bit.
Drop the requirement for VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT because (a)
it is unneeded and (b) it may intefere with finding a type that supports
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT.
Fail if protected mode is requested on the cmdline because host-visible
protected memory is useless and contradictory.