-
Notifications
You must be signed in to change notification settings - Fork 10
S2025 Perception Merge #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: s2025
Are you sure you want to change the base?
Conversation
krishauser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes requested.
…ion.py, left GazeboAgentDetector
krishauser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure of the sensor fusion code is not conformant to GEMstack. You cannot be launching random ROS nodes. PR is not approved, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a ROS node in GEMstack? The architecture doesnt make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PointPillars requires specific package versions which have dependency issues with GEMstacks packages so it cannot be directly integrated into GEMstack. This is why we needed to create a docker container in order to use it. It was written as a ROS node so that it could communicate with GEMstack. I can't think of any other way to integrate PointPillars with GEMstack? Is there something I am unaware of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got rid of the YOLO node to make the code conformant to GEMstack. I cannot remove the PointPillars node because it needs to be run in a docker container due to the package dependency issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before creating the docker container, I spoke to Rachel about the issues I was having with integrating the AI models directly into GEMstack due to the package dependency issues I kept running into. I mentioned that the models required specific package versions that conflicted with GEMstack and prevented direct integration (unless I could downgrade some of the vehicle’s packages). I asked her if it would be possible to downgrade package versions on the vehicle to directly integrate the model(s) I had been trying to directly integrate. I also asked if I could set up a docker container and run a node inside of it as a worst case scenario to integrate another model for the sensor fusion work. She directed me to Jiaming to get my software questions answered. I messaged Jiaming on slack and he said that I could not downgrade the torch version (something which I needed to do for all of the models we looked into) but did say that he didn’t see any issue with setting up a docker container on the vehicle and additionally suggested that I could maybe try use a virtual environment if I couldn’t directly integrate the model(s) into GEMstack. I did not speak to you about whether or not a docker container would be okay because I had already spoken to them about it and they didn’t have any issues with it. I can provide the Jiaming slack messages if needed.
I was not able to get the virtual environment to work due to reasons that I have documented in the shared google document but I was able to create a docker container and set up PointPillars inside of it. I had to set up PointPillars inside of its own ROS node so that it could communicate outside of the docker container with the running Combined Detector which was fully integrated into GEMstack with our launch file.
I would really appreciate it if you could accept our pull request.
…that was missed. Removed YOLO node that was missed.
|




Updated perception stack with cones, pedestrians, sensor fusion bug fixes.
Some of our commit history reset merging with s2025. Please check #223 if you're interested in that.