-
Notifications
You must be signed in to change notification settings - Fork 10
Creeping fix #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: s2025
Are you sure you want to change the base?
Creeping fix #235
Conversation
|
Hello Professor, I know it says there is a duplication issue, this is because the code is very much based on plannings original code. Can you please excuse this. |
|
|
Hello Professor, I handled the duplicate code issues, I believe the code passes all the sonarcloud analysis tests. Can you take a look once and approve Professor? |
krishauser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no plan or justification for how this fits in with the other control components, when it is triggered, etc. PR not approved.
|
I want to clarify that the committed code is independent of controls PR, as it was originally developed for integration with the planning and parking teams. And please let me know if there are any other details I can provide for this PR. |



Hello Professor,
I have updated my other branch (creep-parking-planning) to resolve the issues. These were not issues with my file, as there were other integration changes from parking and planning. I hope the code can be resolved through that PR now. I just wanted to make sure the code gets approved so I decided to create this branch.
The only difference with this code and s2025 is the addition of my creeping planner.
The code I have included is in Gemstack/onboard/planning/creep_planning.py
This should resolve the issues.