Skip to content

Conversation

@Henry-YiW
Copy link
Collaborator

@Henry-YiW Henry-YiW commented May 16, 2025

I used the code and model to test the performance of the lane detection which is a bounty task. Although, due to that the pretrained model was not suitable for detection of the narrow lane in high-bay, it could detect the lanes in real street.

@Henry-YiW Henry-YiW requested a review from krishauser as a code owner May 16, 2025 09:32
Copy link
Owner

@krishauser krishauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"lanes" is not a valid output to the state. I am not sure how this even ran. The use of "RoadgraphSimpleLane" rather than RoadgraphLane is also not justified. PR not approved.

@Henry-YiW
Copy link
Collaborator Author

@krishauser Hi, Professor Hause, since it is not good to use my customized in-house-used-only "RoadgraphSimpleLane" and "lanes" output (for the "lanes" output to be used, I need to coordinate with other team's codes). I upload the offboard code that I used to test the model on the output images recorded from the front camera of the G4 vehicle to the offboard folder and include the README.md that instructs how to use it.

@Henry-YiW Henry-YiW requested a review from krishauser May 16, 2025 20:36
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
40.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants