Support customVariable in GoogleAnalytics#5
Open
isleshocky77 wants to merge 5 commits intokriswallsmith:masterfrom
Open
Support customVariable in GoogleAnalytics#5isleshocky77 wants to merge 5 commits intokriswallsmith:masterfrom
isleshocky77 wants to merge 5 commits intokriswallsmith:masterfrom
Conversation
Conflicts: lib/tracker/sfGoogleAnalyticsTracker.class.php
…equests The option is named "insert_custom_vars_if_ajax". When it's set, in ajax requests, if custom vars have been defined, the tracker will be inserted but will contain only the push for these vars, this is no a full re-declaration. You still need to push the _trackPageView or _trackEvent with js, for example. This is primary designed like this to work with pjax, because a) the custom vars may change over the pages loaded in pjax b) pjax push the _trackPageView at the end of each request This have been implemented only in the async tracker.
Conflicts: lib/tracker/sfGoogleAnalyticsTrackerAsynchronous.class.php lib/tracker/sfGoogleAnalyticsTrackerGoogle.class.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Defined variables is supposed to be deprecated. This code allows for the use of a customVariable.