Merged
Conversation
…r menus and informational popups on click
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #
Related Tickets: TRAIL-39 https://jira.atlassian.krum.io/browse/TRAIL-39?atlOrigin=eyJpIjoiNWFjMjg5MmZlZWE3NDUwN2JjMzcxNTM0YzBlM2RiODciLCJwIjoiaiJ9
Adds a new web component to the trailhand-ui library. The popover appears on click of a slotted trigger element, accepts arbitrary content via slots, supports four placement positions, optional title/subtitle header, a stay-open mode, and automatic dark mode support via the existing CSS variable system.
Type of Change
Changes Made
Primary Changes
Secondary/Collateral Changes
Technical Notes
Files Modified
Implementation Details
position: absoluteon the popover content relative to theposition: relativehost, no external floating UI library dependency, consistent with the existingaction-menupatterndocument.addEventListener('click', ...)pattern asaction-menu, registered inconnectedCallbackand cleaned up indisconnectedCallback_renderHeader()returns nothing when neither title nor the heading slot is populated, so no empty space or border is rendered for bare content popoverstransformoffsets per placement direction (e.g.translateY(-6px)→translateY(0))so the popover slides in from the correct sideTesting
How to Test
Test Coverage
Browsers Tested
Potential Regressions
Screenshots / Videos
Checklist
Additional Context