Conversation
| #function converts word to lower case and provides special rules for irish and turkish since they are not covered by the book | ||
| def toLower(input_string : str, language: str) -> str: | ||
| irish_vowels = "AEIOUÁÉÍÓÚ" | ||
| tilda_ord = 771 |
There was a problem hiding this comment.
There is something more general going on here that you'll want to handle in general, not just for this one combining diacritics. We'll discuss in class when we get into Unicode more deeply, or you can stop by office hours if you're curious.
| # ord 771 since that means that there is a tild on the second alphabet since that could be achieved by either a singular unicode or by 2 unicodes | ||
| # this is the reason we only check at postion[2] since if there is a tilda at [2] it means there can't be a vowel at [1] | ||
|
|
||
| if(language.find("ga") + 1): |
There was a problem hiding this comment.
!= -1 would be more readable. Also, this isn't exactly correct, since there are 3-letter language codes in ISO 639-3, and so this would work for "gaa", for example (Ga language spoken in Ghana).
| # this is the reason we only check at postion[2] since if there is a tilda at [2] it means there can't be a vowel at [1] | ||
|
|
||
| if(language.find("ga") + 1): | ||
| irish_lower = lambda input_string : (input_string[0] + "-" + input_string[1:]).lower() \ |
There was a problem hiding this comment.
A bit odd to do this as a lambda. Why not just apply these lines of code directly to the object with the same name?
| return irish_lower(input_string) | ||
|
|
||
| # Turkish and Azerbaijani follow similar rules to standard covertion with just a different i | ||
| elif((language.find("tr") + 1) or (language.find("az") + 1)): |
|
|
||
| # Turkish and Azerbaijani follow similar rules to standard covertion with just a different i | ||
| elif((language.find("tr") + 1) or (language.find("az") + 1)): | ||
| return input_string.lower().replace("i", "ı") |
There was a problem hiding this comment.
I don't believe this behaves the way we want. Did you test with both dotted and non-dotted uppercase?
There was a problem hiding this comment.
You really need a lot more tests, since they might turn up additional bugs.
| return input_string.lower().replace("i", "ı") | ||
|
|
||
| else: | ||
| return input_string.lower() |
There was a problem hiding this comment.
The problem description asked for an optimization for languages without case.
2 participants
Sorry I won't be present for the code review lab. But this is my submission for the programming assignment.