Remove redundant AAB signing step and update Google Play action version#1446
Draft
ksharma-xyz wants to merge 1 commit intomainfrom
Draft
Remove redundant AAB signing step and update Google Play action version#1446ksharma-xyz wants to merge 1 commit intomainfrom
ksharma-xyz wants to merge 1 commit intomainfrom
Conversation
ksharma-xyz
changed the title
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Owner
Author
|
Update if any issues arise due to node version |
ksharma-xyz
changed the base branch from
03-16-add_workflow_dispatch_maunal_trigger_for_google_play_publish
to
graphite-base/1446
ksharma-xyz
force-pushed
the
03-17-fix_warnings
branch
from
43c9f74 to
e382ba1
Compare
ksharma-xyz
force-pushed
the
graphite-base/1446
branch
from
283fa50 to
476acb0
Compare
ksharma-xyz
force-pushed
the
03-17-fix_warnings
branch
from
e382ba1 to
1e90a26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Removed redundant AAB signing step from Android build workflow and updated Google Play upload action to latest version.
What changed?
Sign Android Release AABstep from the build workflow since Gradle'ssigningConfigalready signs the AAB during thebundleReleasetaskr0adkll/upload-google-playfromv1tov1.1.3in the Google Play distribution workflowHow to test?
androidApp/build/outputs/bundle/release/androidApp-release.aabWhy make this change?
The separate AAB signing step was redundant since the Gradle build configuration already handles signing during the bundle creation process. This simplifies the workflow and removes an unnecessary dependency on the
filippoLeporati93/android-release-signeraction. The Google Play upload action was updated to the latest available version while maintaining Node.js 20 compatibility.