Skip to content

Merge release to main#5568

Closed
bjhham wants to merge 1 commit intomainfrom
release/3.x
Closed

Merge release to main#5568
bjhham wants to merge 1 commit intomainfrom
release/3.x

Conversation

@bjhham
Copy link
Copy Markdown
Contributor

@bjhham bjhham commented Apr 30, 2026

No description provided.

…andler (#5563)

* KTOR-646 Log client-disconnect IOException at TRACE in Netty HTTP/1 handler

* Address review feedback: simplify test name and remove redundant detach
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e65f4e43-2af0-4b45-b4ae-b38f527d03a4

📥 Commits

Reviewing files that changed from the base of the PR and between 86fd3cb and e223d1e.

📒 Files selected for processing (2)
  • ktor-server/ktor-server-netty/jvm/src/io/ktor/server/netty/http1/NettyHttp1Handler.kt
  • ktor-server/ktor-server-netty/jvm/test/io/ktor/tests/server/netty/NettySpecificTest.kt

📝 Walkthrough

Walkthrough

This PR changes the log level for IOException handling in NettyHttp1Handler from debug to trace level, and adds a Netty-specific test that validates this logging behavior by capturing and asserting trace-level log emissions during simulated client disconnects.

Changes

Cohort / File(s) Summary
Handler logging level
ktor-server/ktor-server-netty/jvm/src/io/ktor/server/netty/http1/NettyHttp1Handler.kt
Changed IOException log statement from debug to trace level in exceptionCaught method while preserving existing control flow (job cancellation and channel closure).
Logging behavior validation
ktor-server/ktor-server-netty/jvm/test/io/ktor/tests/server/netty/NettySpecificTest.kt
Added test that verifies trace-level logging for IOException in NettyHttp1Handler using Logback ListAppender capture, EmbeddedChannel simulation, and proper resource cleanup.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/3.x

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@bjhham bjhham closed this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants