Skip to content

Merge release to main#5569

Merged
bjhham merged 2 commits intomainfrom
bjhham/release_merge
Apr 30, 2026
Merged

Merge release to main#5569
bjhham merged 2 commits intomainfrom
bjhham/release_merge

Conversation

@bjhham
Copy link
Copy Markdown
Contributor

@bjhham bjhham commented Apr 30, 2026

No description provided.

…andler (#5563)

* KTOR-646 Log client-disconnect IOException at TRACE in Netty HTTP/1 handler

* Address review feedback: simplify test name and remove redundant detach
@bjhham bjhham added the --ff-only This PR should merged with fast-forward label Apr 30, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b0ab347d-f466-4e97-b964-2ccc6a1f2716

📥 Commits

Reviewing files that changed from the base of the PR and between 97cc35a and 69ed967.

📒 Files selected for processing (2)
  • ktor-server/ktor-server-netty/jvm/src/io/ktor/server/netty/http1/NettyHttp1Handler.kt
  • ktor-server/ktor-server-netty/jvm/test/io/ktor/tests/server/netty/NettySpecificTest.kt
✅ Files skipped from review due to trivial changes (1)
  • ktor-server/ktor-server-netty/jvm/src/io/ktor/server/netty/http1/NettyHttp1Handler.kt

📝 Walkthrough

Walkthrough

Downgrade of logging level for IOException in NettyHttp1Handler.exceptionCaught from DEBUG to TRACE, plus a new unit test that asserts a single "I/O operation failed" message is emitted at TRACE when a client-disconnect-style IOException occurs.

Changes

Cohort / File(s) Summary
Logging Level Adjustment
ktor-server/ktor-server-netty/jvm/src/io/ktor/server/netty/http1/NettyHttp1Handler.kt
Changed logging for IOException in exceptionCaught from debug to trace; existing behavior of cancelling handlerJob and closing the Netty context is preserved.
Test Addition
ktor-server/ktor-server-netty/jvm/test/io/ktor/tests/server/netty/NettySpecificTest.kt
Added a unit test that configures a Logback ListAppender, invokes exceptionCaught on an EmbeddedChannel with IOException("Connection reset by peer"), and asserts exactly one "I/O operation failed" event at TRACE level.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • PR #5563: Same change to lower IOException logging to TRACE in NettyHttp1Handler.exceptionCaught and adds an equivalent Netty-specific test verifying trace-level logging.
🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author, but the template requires subsystem, motivation, and solution sections. Add a complete description following the template with subsystem, motivation explaining the problem/ticket, and solution describing the changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Merge release to main' is generic and does not convey meaningful information about the actual changes, which involve logging level adjustments and test additions. Use a more descriptive title that reflects the actual changes, such as 'Change IOException logging level from debug to trace in NettyHttp1Handler' or include specific details about what is being merged.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bjhham/release_merge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@bjhham bjhham added the 👍 ship! This pull request can be shipped bypassing review. Read about "Ship/Show/Ask" strategy for more info label Apr 30, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! :shipit:

@bjhham bjhham force-pushed the bjhham/release_merge branch from 97cc35a to 69ed967 Compare April 30, 2026 10:20
@bjhham bjhham merged commit fdcc4bf into main Apr 30, 2026
15 of 17 checks passed
@bjhham bjhham deleted the bjhham/release_merge branch April 30, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

--ff-only This PR should merged with fast-forward 👍 ship! This pull request can be shipped bypassing review. Read about "Ship/Show/Ask" strategy for more info

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants