Skip to content

refactor: delete idl dependency and delete unused errors #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stdll00 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: delete idl dependency and delete unused errors #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e511a5d
refactor: delete idl dependency and delete unused errors
stdll00 Nov 26, 2023
380ab42
Merge branch 'master' into refactor/delete-idl-package
stdll00 Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions idl/idl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,6 @@ import (
"github.com/ktr0731/evans/grpc"
)

var (
ErrPackageUnselected = errors.New("package unselected")
ErrServiceUnselected = errors.New("service unselected")

ErrUnknownPackageName = errors.New("unknown package name")
ErrUnknownServiceName = errors.New("unknown service name")
ErrUnknownRPCName = errors.New("unknown RPC name")
ErrUnknownSymbol = errors.New("unknown symbol")
)

// Spec represents the interface specification from loaded IDL files.
type Spec interface {
// ServiceNames returns all service names the spec loaded.
Expand Down
5 changes: 2 additions & 3 deletions repl/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (

"github.com/ktr0731/evans/format"
"github.com/ktr0731/evans/format/curl"
"github.com/ktr0731/evans/idl"
"github.com/ktr0731/evans/usecase"
"github.com/pkg/errors"
"github.com/spf13/pflag"
Expand Down Expand Up @@ -94,9 +93,9 @@ func (c *serviceCommand) Validate(args []string) error {
func (c *serviceCommand) Run(_ io.Writer, args []string) error {
err := usecase.UseService(args[0])
switch errors.Cause(err) {
case idl.ErrPackageUnselected:
case usecase.ErrPackageUnselected:
return errors.New("package unselected. please execute 'package' command at the first")
case idl.ErrUnknownServiceName:
case usecase.ErrUnknownServiceName:
return errors.Errorf("unknown service name '%s'", args[0])
}
return err
Expand Down