Skip to content

🧹 Fix: explicit 'any' type on Window object in ModeSwitch#1035

Open
kuasar-mknd wants to merge 1 commit intomasterfrom
fix/code-health-modeswitch-5288882113611961188
Open

🧹 Fix: explicit 'any' type on Window object in ModeSwitch#1035
kuasar-mknd wants to merge 1 commit intomasterfrom
fix/code-health-modeswitch-5288882113611961188

Conversation

@kuasar-mknd
Copy link
Copy Markdown
Owner

🎯 What: The explicit 'any' type assertion on the global window object in src/components/ui/ModeSwitch.astro has been removed. The __handleThemeChange property is now explicitly typed as an extension of the Window interface in src/env.d.ts.
💡 Why: Extending the global Window interface improves codebase maintainability, type safety, and readability. It prevents TypeScript errors natively without resorting to the 'any' escape hatch, ensuring that any future references to __handleThemeChange benefit from proper IDE autocomplete and type validation.
Verification: I ran formatting checks, the Astro linter/typechecker (pnpm run check), successfully built the project (pnpm run build), and successfully passed the Playwright end-to-end tests (pnpm run test:e2e).
Result: The ModeSwitch component uses proper type checking on the Window object and no longer relies on explicit any bypassing.


PR created automatically by Jules for task 5288882113611961188 started by @kuasar-mknd

@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions bot enabled auto-merge (squash) March 15, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant