Skip to content

🧹 Remove explicit any on window in Hero.astro#1036

Open
kuasar-mknd wants to merge 1 commit intomasterfrom
fix/remove-any-hero-window-10428157274451334835
Open

🧹 Remove explicit any on window in Hero.astro#1036
kuasar-mknd wants to merge 1 commit intomasterfrom
fix/remove-any-hero-window-10428157274451334835

Conversation

@kuasar-mknd
Copy link
Copy Markdown
Owner

🎯 What: The explicit window as any cast and its associated eslint-disable override have been removed from src/components/features/home/Hero.astro. To support type safety, __heroInitHandler has been properly declared on the global Window interface in src/env.d.ts.

💡 Why: Relying on any bypasses TypeScript checks and makes the code less robust to refactoring. By extending the built-in Window interface directly, we improve code health, ensure the listener's types are checked appropriately globally, and remove unnecessary eslint ignores.

Verification:

  • Modified src/env.d.ts and src/components/features/home/Hero.astro.
  • Ran pnpm run check (formatter, linter, and type checker) locally. All passed successfully.
  • Ran pnpm run build locally, completing without issues.
  • Installed playwright deps and ran pnpm run test:e2e. All E2E tests passed.

Result: A safer, more robust implementation without an explicit type override or linting ignore, adhering to the codebase's existing pattern of global interface augmentation.


PR created automatically by Jules for task 10428157274451334835 started by @kuasar-mknd

@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions bot enabled auto-merge (squash) March 15, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant