Skip to content

🧹 [code health improvement] Fix 'any' typing in VideoPlayer by augmenting Window interface#1040

Open
kuasar-mknd wants to merge 1 commit intomasterfrom
code-health/fix-any-typing-videoplayer-11866459605519206435
Open

🧹 [code health improvement] Fix 'any' typing in VideoPlayer by augmenting Window interface#1040
kuasar-mknd wants to merge 1 commit intomasterfrom
code-health/fix-any-typing-videoplayer-11866459605519206435

Conversation

@kuasar-mknd
Copy link
Copy Markdown
Owner

🎯 What: The code health issue addressed was the use of // eslint-disable-next-line @typescript-eslint/no-explicit-any and window as any in src/components/features/projects/VideoPlayer.astro to bypass TypeScript rules for custom event handlers. Replaced any with strongly typed augmentations to the Window interface in src/env.d.ts (__videoPlayerClickHandler, __videoPrefetchDelegationInitialized, _plyrPrefetched, __videoPlayerLoadHandler).

💡 Why: Relying on any bypasses TypeScript's safety mechanisms and makes the code harder to maintain. Properly typing the window object enforces type safety for singleton listener patterns.

Verification: Verified by running the local validation suite (pnpm run check, pnpm run build, and pnpm run test:e2e). All formatting, linting, typechecks, builds, and tests passed.

Result: Improved type safety and maintainability in the VideoPlayer.astro component while eliminating the need for any casting.


PR created automatically by Jules for task 11866459605519206435 started by @kuasar-mknd

…ting Window interface

Removed the use of `// eslint-disable-next-line @typescript-eslint/no-explicit-any` and `window as any` in `src/components/features/projects/VideoPlayer.astro` for initializing singleton event listeners. Replaced `any` bypasses with strongly typed augmentations to the global `Window` interface in `src/env.d.ts`. Verified by running `pnpm run check`, `pnpm run build`, and `pnpm run test:e2e`.
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant