Skip to content

🧹 Code Health: Remove explicit 'any' from Window object references#1041

Open
kuasar-mknd wants to merge 1 commit intomasterfrom
jules-13287509590737774229-780a8e85
Open

🧹 Code Health: Remove explicit 'any' from Window object references#1041
kuasar-mknd wants to merge 1 commit intomasterfrom
jules-13287509590737774229-780a8e85

Conversation

@kuasar-mknd
Copy link
Copy Markdown
Owner

🎯 What: Addressed a typing code health issue where the global window object was being explicitly cast to any (via const win = window as any;) with accompanying eslint-disable comments.
💡 Why: Extending the global Window interface with the specific singleton properties used across the application ensures true type-safety during the build and prevents regressions. It cleans up unnecessary code duplication (the any casts) and removes ESLint warning overrides.
Verification: Ran pnpm run check which checks linting, formatting, and Astro typechecking. Confirmed there were zero typescript errors or lint warnings. Followed up by running the playwright end-to-end tests to ensure functionality remained unbroken.
Result: A safer, cleaner, and fully typed pattern for global object access without resorting to any.


PR created automatically by Jules for task 13287509590737774229 started by @kuasar-mknd

@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant