🧹 Code Health: Remove explicit 'any' from Window object references#1041
🧹 Code Health: Remove explicit 'any' from Window object references#1041kuasar-mknd wants to merge 1 commit intomasterfrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Addressed a typing code health issue where the global
windowobject was being explicitly cast toany(viaconst win = window as any;) with accompanyingeslint-disablecomments.💡 Why: Extending the global
Windowinterface with the specific singleton properties used across the application ensures true type-safety during the build and prevents regressions. It cleans up unnecessary code duplication (the any casts) and removes ESLint warning overrides.✅ Verification: Ran
pnpm run checkwhich checks linting, formatting, and Astro typechecking. Confirmed there were zero typescript errors or lint warnings. Followed up by running theplaywrightend-to-end tests to ensure functionality remained unbroken.✨ Result: A safer, cleaner, and fully typed pattern for global object access without resorting to
any.PR created automatically by Jules for task 13287509590737774229 started by @kuasar-mknd