🧹 Code Health: Remove explicit 'any' from Lightbox.astro#1043
🧹 Code Health: Remove explicit 'any' from Lightbox.astro#1043kuasar-mknd wants to merge 1 commit intomasterfrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What:
Removed
window as anycast and added strict typings for the custom properties attached to the globalWindowobject used by the Lightbox component.💡 Why:
Using
anydisables TypeScript's type checking, making the codebase more prone to errors and harder to refactor. Extending the globalWindowinterface improves code maintainability and enforces strict types throughout the Astro components.✅ Verification:
Ran
pnpm run check(formatter, linter, typecheck). All passing without any explicit any warnings. Ran the full E2E test suite with Playwright and all 7 tests passed (including the Lightbox specific tests).✨ Result:
Cleaner, strictly typed code without
anycasts oreslint-disablecomments.PR created automatically by Jules for task 5764700744994571687 started by @kuasar-mknd