Skip to content

🧹 [code health improvement] Remove explicit 'any' from window object and augment Window interface#1044

Open
kuasar-mknd wants to merge 1 commit intomasterfrom
jules-13684531248846941080-8817f6a5
Open

🧹 [code health improvement] Remove explicit 'any' from window object and augment Window interface#1044
kuasar-mknd wants to merge 1 commit intomasterfrom
jules-13684531248846941080-8817f6a5

Conversation

@kuasar-mknd
Copy link
Copy Markdown
Owner

🎯 What: Removed the explicit 'any' type cast for the window object in various .astro files and augmented the Window interface in src/env.d.ts to type custom singleton properties properly.
💡 Why: Overusing any bypasses TypeScript checks. By strictly typing properties on Window, we enforce type safety for DOM event listeners and state flags, removing ESLint ignore directives.
Verification: Ran pnpm check (format, lint, typecheck) to ensure code compiles and follows standards. Verified locally with Playwright E2E tests, which all passed, confirming that the changes introduce no functional side effects.
Result: Better type safety, cleaner source files without ESLint comments, and improved code autocompletion.


PR created automatically by Jules for task 13684531248846941080 started by @kuasar-mknd

@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant