Skip to content

🧹 [code health improvement] Augment Window type to replace 'window as any' castings#1045

Open
kuasar-mknd wants to merge 1 commit intomasterfrom
code-health/augment-window-type-11506260394677494612
Open

🧹 [code health improvement] Augment Window type to replace 'window as any' castings#1045
kuasar-mknd wants to merge 1 commit intomasterfrom
code-health/augment-window-type-11506260394677494612

Conversation

@kuasar-mknd
Copy link
Copy Markdown
Owner

🎯 What: The global Window interface was extended in src/env.d.ts to include strongly-typed custom properties used across multiple components. This allowed the complete removal of unsafe window as any type assertions and // eslint-disable-next-line @typescript-eslint/no-explicit-any comments throughout the codebase.

💡 Why: Relying on explicit any casting bypasses the TypeScript compiler, leaving the code vulnerable to typos and type mismatches. Defining the custom properties directly on the global Window interface improves type safety, developer experience (through IDE autocompletion), and overall maintainability.

Verification: Verified by compiling the application (pnpm run build), running the TypeScript compiler (pnpm run typecheck), linting (pnpm run lint), and successfully running the e2e Playwright test suite.

Result: A safer, cleaner, and strictly typed codebase with 0 eslint-disable workarounds regarding window accesses.


PR created automatically by Jules for task 11506260394677494612 started by @kuasar-mknd

@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant