Skip to content

🧹 Remove explicit 'any' from window object and strongly type custom properties#1046

Open
kuasar-mknd wants to merge 1 commit intomasterfrom
fix/window-any-typing-15537727034846077092
Open

🧹 Remove explicit 'any' from window object and strongly type custom properties#1046
kuasar-mknd wants to merge 1 commit intomasterfrom
fix/window-any-typing-15537727034846077092

Conversation

@kuasar-mknd
Copy link
Copy Markdown
Owner

🎯 What: Removed the explicit any type assertion on the window object (const win = window as any;) across multiple .astro files and correctly extended the Window interface in src/env.d.ts with strict types for all attached custom properties used for singleton listeners and logic.
💡 Why: Explicit any assertions bypass TypeScript's type checking, creating a risk for typos and unsafe property access. By adding these global event handlers and observer properties to the global Window interface, we achieve full type safety and clearer developer intent. It conforms better to the @typescript-eslint/no-explicit-any linting rule.
Verification: Ran pnpm run check (formatter, linter, type checker), which successfully passed. Also ran pnpm run build and pnpm run test:e2e, verifying that these refactors did not introduce any regressions and end-to-end functionality (like lightbox, theme toggle, auto-resizing textareas) remains completely intact.
Result: A safer, more robustly typed codebase with properly defined global singleton listeners and better DX due to autocompletion for window.__* properties.


PR created automatically by Jules for task 15537727034846077092 started by @kuasar-mknd

@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant