🧹 Code Health: Remove explicit 'any' type for Window object#1048
🧹 Code Health: Remove explicit 'any' type for Window object#1048kuasar-mknd wants to merge 1 commit intomasterfrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Removed explicit
anycasting forWindowobjects (const win = window as any;) throughout the.astrofiles.💡 Why: By using the explicit type
anyonwindow, we were abandoning TypeScript's type-safety benefits. Extending theWindowinterface properly insidesrc/env.d.tswith custom properties enables safe global state usage and removes lint disabling directives (// eslint-disable-next-line @typescript-eslint/no-explicit-any). This vastly improves the codebase's readability and correctness without changing existing behaviors.✅ Verification:
pnpm run lint) to ensure the codebase abides by existing rules.pnpm run typecheck(astro check) and verified0 errors.windowstate were unaffected.✨ Result: Safe, type-checked implementations globally in all UI components and layouts utilizing the custom interactive variables mapped to
window.PR created automatically by Jules for task 4819259879335121778 started by @kuasar-mknd