⚡ Bolt: Cache window.matchMedia string parsing#1148
⚡ Bolt: Cache window.matchMedia string parsing#1148github-actions[bot] merged 1 commit intomasterfrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Cached the
window.matchMedia("(prefers-reduced-motion: reduce)")call to the module level insrc/components/ui/ScrollReveal.astroand evaluated the.matchesproperty inside the initialization function instead.🎯 Why: In Astro projects, components like
ScrollReveal.astrorun their initialization logic not just on page load, but also after every view transition (astro:page-load). Re-evaluatingwindow.matchMedia()insideinitScrollReveal()forces the browser to repeatedly parse the media query string, leading to unnecessary overhead and potentially impacting page load performance or triggering micro-stutters during View Transitions.📊 Impact: Reduces memory allocation and avoids the CPU string parsing penalty by using the cached
MediaQueryListobject, leading to faster re-initialization of components. This is a very standard and safe micro-optimization pattern.🔬 Measurement: Verifiable via
pnpm run checkandbun test src/ tests/. Tests passed successfully without introducing any regressions. No further performance overhead expected from re-parsing the media query.PR created automatically by Jules for task 15485780458772638527 started by @kuasar-mknd