-
Couldn't load subscription status.
- Fork 1
feat: add dry-run mode #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
|
debug and debugMode can be confusing at first. why not just use debug and put all these feature behind a single flag? if it makes sense to control for example persistence separately, I would add a flag for that specifically |
|
Persistence is controlled by a single flag on tenant's level. The power of debug-mode is to have a hassle free method for testing out the whole pipeline without having to worry about which components to enable/disable to have no side-effects. The current validation layer catches all syntax errors before deploying, but runtime errors/misconfigurations such as invalid/not at all working ottl statements, might not show up at all. |
|
Still not sure why we need both debug and debugmode flags at the same time |
|
Debug, essentially adds a debug exporter next to the configured ones, it also raises the log level of all components to debug. |
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
792859b to
4bb878f
Compare
|
I've changed the naming from debug-mode to dry-run mode. |
Introduces a new
dryRunModethat enables a simplified pipeline configuration for testing and debugging purposes.dryRunModeto thecollectorCRD.dryRunModecan only be enabled whendebugis also set.When
dryRunModeis enabled:This feature is particularly useful for: