chore: Remove dependency on home crate, use std instead #1840
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have CI problems related to the home crate, so I looked up what that crate is doing. In it's description it states that Rust 1.85.0 fixed the Windows HOME problems and users are encouraged to use std instead. So I did exactly that, as kube's MSRV is 1.85.0. Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.tech>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1840 +/- ##
=======================================
+ Coverage 74.5% 74.6% +0.1%
=======================================
Files 84 84
Lines 7877 7877
=======================================
+ Hits 5867 5869 +2
+ Misses 2010 2008 -2
🚀 New features to boost your workflow:
|
clux
reviewed
Nov 3, 2025
Comment on lines
+668
to
+669
| // Note: We intentionally use `allow` over `expect` to support compilation on Rust >= 1.87.0 | ||
| // Note: This can be removed once the MSRV is bumped to >= 1.87.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have CI problems related to the
homecrate (#1839), so I looked up what that crate is doing.Solution
In it's description it states that Rust 1.85.0 fixed the Windows HOME problems and users are encouraged to use
stdinstead.So I did exactly that, as kube's MSRV is 1.85.0.