fix(examples): add missing runtime dependencies for cloud-edge LLM example#324
fix(examples): add missing runtime dependencies for cloud-edge LLM example#324iashutoshyadav wants to merge 1 commit intokubeedge:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iashutoshyadav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @iashutoshyadav, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses missing runtime dependencies for the cloud-edge LLM example, which is a valuable fix. The changes in requirements.txt correctly add several necessary packages. However, I've noticed a couple of duplicate dependency entries (openai and groq) that should be removed to keep the file clean. My review comment points out these specific redundancies and suggests a fix.
| vllm | ||
| transformers | ||
| openai | ||
| accelerate | ||
| datamodel_code_generator | ||
| kaggle | ||
| groq No newline at end of file | ||
| groq |
There was a problem hiding this comment.
This block of dependencies appears to be the contents of the original requirements.txt file. However, openai and groq are now also specified on lines 14 and 15, making them duplicates. To keep the dependency list clean and avoid redundancy, please remove the duplicated entries from this block.
vllm
transformers
accelerate
datamodel_code_generator
kaggle
Signed-off-by: Ashutosh Yadav <ashutosh2213072@akgec.ac.in>
2eea313 to
f757da4
Compare
What does this PR do?
Fixes missing runtime dependencies in the
examples/cloud-edge-collaborative-inference-for-llmexample that causesequential
ModuleNotFoundErrorfailures in a fresh environment.Issues observed
Running the example fails due to missing dependencies:
prettytable– result visualizationonnx– required by MultiedgeInferenceretry– required by API-based LLM modulecolorlog,pyyaml– required by ianvs runtimetokenizersThese were not fully documented or included in the example requirements,
blocking new users from running the benchmark successfully.
What was changed
examples/cloud-edge-collaborative-inference-for-llm/requirements.txtto include missing Python runtime dependencies
How it was tested
Related issue
Fixes #322